Added search and history tests #451
Conversation
Added multiple_selection field test to test_very_parametrized_script.py
|
|
||
| @property | ||
| def all_groups(self): | ||
|
|
|
|
||
| @property | ||
| def history_table_column_titles(self): | ||
| return ["ID", "Start Time", "User", "Script", "Status"] |
|
|
||
| @property | ||
| def history_table(self): | ||
| return self.find_element("div.executions-log-table tr") |
There was a problem hiding this comment.
Why do you return "tr" as a "history table" ? tr is only a single row
Please either remove the tr from here or rename the method name
| home_page.load() | ||
|
|
||
| home_page.sidebar_search_button.click() | ||
| home_page.sidebar_search_input.send_keys(search_request) |
There was a problem hiding this comment.
Please replace the variable with the string literal, it makes the test easier to read
| displayed_results = home_page.all_script_links + home_page.all_groups | ||
|
|
||
| for result in displayed_results: | ||
| expect(str(result.text).find(search_request) > -1, "\"{}\" containts no search request \"{}\" but still listed after search".format(str(result.text), search_request)) |
There was a problem hiding this comment.
Since you are working with a predefined set of scripts, I think it would be more transparent to verify, that "display_result" is equal to an array of some elements
| very_parametrized_script_page = VeryParametrizedScript(browser, config_host) | ||
| very_parametrized_script_page.parameter_multiple_selection.click() | ||
|
|
||
| expect(is_displayed(very_parametrized_script_page.parameter_multiple_selection_drop_down), "Drop down for Multiple selection not found after click") |
There was a problem hiding this comment.
Do we really need this test? It would be covered by the next test anyway
| expect("selected" not in random_option.get_attribute("class").split(" "), "Checked options stays selected after click on it") | ||
| random_option.click() | ||
| expect("selected" in random_option.get_attribute("class").split(" "), "Unchecked options stays not selected after click on it") | ||
| if len(very_parametrized_script_page.parameter_multiple_selection_drop_down_unchecked_elements) > 0: |
There was a problem hiding this comment.
It would be nice to have a blank line before this if
| def test_check_multiple_selection_check_uncheck_action(browser, config_host): | ||
| very_parametrized_script_page = VeryParametrizedScript(browser, config_host) | ||
|
|
||
| if len(very_parametrized_script_page.parameter_multiple_selection_drop_down_checked_elements) > 0: |
There was a problem hiding this comment.
Since you are working with predefined scripts, I think this if is redundant here. You should know what to expect there.
Added multiple_selection field test to test_very_parametrized_script.py
Added search and history tests